+1

 

From: presto-tsc@... <presto-tsc@...> on behalf of Shixuan Fan via lists.prestodb.io <shixuan=fb.com@...>
Date: Tuesday, March 16, 2021 at 4:58 PM
To: presto-tsc@... <presto-tsc@...>
Subject: [presto-tsc] Nominating James Petty as new committer

Hi TSC members,

 

I'd like to nominate James Petty as a committer. James has been working on Presto for a little over 2 years, first as part of the AWS Athena team and now as a member of the EMR performance team. Some of his contribution highlights include:

* Reducing sources of lock contention throughout the engine (prestodb#15509, prestodb#15477)

* Reducing coordinator heap pressure from Glue metastore partitions (prestodb#15389)

* Various bug fixes, including a fix for a long standing accounting issue with memory revoking (prestodb#15569)

* Implementing spill to disk compression and encryption (prestodb#12617)

* making query result GZIP compression configurable (prestodb#15393)

The full list of his commits can be found here: https://github.com/prestodb/presto/commits?author=pettyjamesm

Per the TSC charter "A Contributor may become a Committer by a majority approval of the existing Committers.", therefore, each TSC member has one vote to cast. Please reply with +1/-1 if you approve/disapprove onboarding James as a committer. 

 

Thanks,

Shixuan

+1

 

From: presto-tsc@... <presto-tsc@...> on behalf of Maria Basmanova via lists.prestodb.io <mbasmanova=fb.com@...>
Date: Tuesday, March 16, 2021 at 2:35 PM
To: venkik@... <venkik@...>, Rebecca Schlussel <rschlussel@...>
Cc: Shixuan Fan <shixuan@...>, presto-tsc@... <presto-tsc@...>
Subject: Re: [presto-tsc] Nominating James Petty as new committer

+10

 

From: <presto-tsc@...> on behalf of "venkik via lists.prestodb.io" <venkik=uber.com@...>
Reply-To: "venkik@..." <venkik@...>
Date: Tuesday, March 16, 2021 at 5:35 PM
To: Rebecca Schlussel <rschlussel@...>
Cc: Shixuan Fan <shixuan@...>, "presto-tsc@..." <presto-tsc@...>
Subject: Re: [presto-tsc] Nominating James Petty as new committer

 

+1

 

On Tue, Mar 16, 2021 at 2:33 PM rschlussel via lists.prestodb.io <rschlussel=fb.com@...> wrote:

+1

 

From: presto-tsc@... <presto-tsc@...> on behalf of Shixuan Fan via lists.prestodb.io <shixuan=fb.com@...>
Date: Tuesday, March 16, 2021 at 4:58 PM
To: presto-tsc@... <presto-tsc@...>
Subject: [presto-tsc] Nominating James Petty as new committer

Hi TSC members,

 

I'd like to nominate James Petty as a committer. James has been working on Presto for a little over 2 years, first as part of the AWS Athena team and now as a member of the EMR performance team. Some of his contribution highlights include:

* Reducing sources of lock contention throughout the engine (prestodb#15509, prestodb#15477)

* Reducing coordinator heap pressure from Glue metastore partitions (prestodb#15389)

* Various bug fixes, including a fix for a long standing accounting issue with memory revoking (prestodb#15569)

* Implementing spill to disk compression and encryption (prestodb#12617)

* making query result GZIP compression configurable (prestodb#15393)

The full list of his commits can be found here: https://github.com/prestodb/presto/commits?author=pettyjamesm

Per the TSC charter "A Contributor may become a Committer by a majority approval of the existing Committers.", therefore, each TSC member has one vote to cast. Please reply with +1/-1 if you approve/disapprove onboarding James as a committer. 

 

Thanks,

Shixuan

+1

 

From: presto-tsc@... <presto-tsc@...> on behalf of Shixuan Fan via lists.prestodb.io <shixuan=fb.com@...>
Date: Tuesday, March 16, 2021 at 4:58 PM
To: presto-tsc@... <presto-tsc@...>
Subject: [presto-tsc] Nominating James Petty as new committer

Hi TSC members,

 

I'd like to nominate James Petty as a committer. James has been working on Presto for a little over 2 years, first as part of the AWS Athena team and now as a member of the EMR performance team. Some of his contribution highlights include:

* Reducing sources of lock contention throughout the engine (prestodb#15509, prestodb#15477)

* Reducing coordinator heap pressure from Glue metastore partitions (prestodb#15389)

* Various bug fixes, including a fix for a long standing accounting issue with memory revoking (prestodb#15569)

* Implementing spill to disk compression and encryption (prestodb#12617)

* making query result GZIP compression configurable (prestodb#15393)

The full list of his commits can be found here: https://github.com/prestodb/presto/commits?author=pettyjamesm

Per the TSC charter "A Contributor may become a Committer by a majority approval of the existing Committers.", therefore, each TSC member has one vote to cast. Please reply with +1/-1 if you approve/disapprove onboarding James as a committer. 

 

Thanks,

Shixuan

Hi everyone,

 

It’s come up a few times recently where new functions have been added without documentation, which makes them not very usable.  Since it’s much easier to ensure that documentation gets written if it’s done when the feature is added, I’d like to propose an update to our commit guidelines to say that new functions, language features, etc. need to have documentation included as part of the PR, and we don’t merge without that documentation.

 

What do others think?

 

Rebecca

Makes sense to me too.

 

-Masha

 

From: <presto-tsc@...> on behalf of Ariel Weisberg <ariel@...>
Date: Thursday, March 4, 2021 at 12:18 PM
To: "presto-tsc@..." <presto-tsc@...>
Subject: Re: [presto-tsc] Adding doc requirement to commit guidelines

 

Hi,

 

Agree. It's an implicit requirement IMO, but I see people (sometimes me) forgetting it at both contribution and review time.

 

Ariel

 

On Thu, Mar 4, 2021, at 12:14 PM, rschlussel via lists.prestodb.io wrote:

Hi everyone,

 

It’s come up a few times recently where new functions have been added without documentation, which makes them not very usable.  Since it’s much easier to ensure that documentation gets written if it’s done when the feature is added, I’d like to propose an update to our commit guidelines to say that new functions, language features, etc. need to have documentation included as part of the PR, and we don’t merge without that documentation.

 

What do others think?

 

Rebecca

 

Thank you. We have 8 votes which should be a majority. Per our charter, let's welcome Beinan as our newest committer!

Gale: could you please help add Beinan to the relevant mailing lists and groups?

Thanks,

Zhenxiao

On Sun, Feb 28, 2021 at 1:09 PM Dipti Borkar <dipti@...> wrote:

+1 (non-binding) 

Beinan has been very helpful on the community and Presto foundation side - with presentations on higher level introductions to Presto as well as deeper tech talk sessions. In addition, he has been very helpful with PR reviews on connectors as well as answering user questions and troubleshooting on slack and other community channels. 

Thank you Beinan! 

- Dipti

On Feb 26, 2021, at 9:05 AM, venkik via lists.prestodb.io <venkik=uber.com@...> wrote:



+1

On Fri, Feb 26, 2021 at 9:04 AM Bin Fan <binfan@...> wrote:

+1

thanks for Beinan’s contribution!

Bin

On Fri, Feb 26, 2021 at 8:51 AM Shixuan Fan via lists.prestodb.io <shixuan=fb.com@...> wrote:

+1

 

From: presto-tsc@... <presto-tsc@...> on behalf of zluo via lists.prestodb.io <zluo=twitter.com@...>
Date: Thursday, February 25, 2021 at 2:36 PM
To: presto-tsc@... <presto-tsc@...>
Subject: [presto-tsc] Nominating Beinan Wang as new committer

 

Hi TSC members,

 

I'd like to nominate Beinan Wang as a committer. Beinan has been working on Presto for 2+ years. Some of his contributions highlights:

• Presto Google Cloud Storage(GCS) connector with authentication and authorization
• Presto Druid connector with aggregation pushdowns
• bug fixes and support for Parquet and dereference pushdown in Presto

Here are Beinan's whole commits:

https://github.com/prestodb/presto/commits?author=beinan

 

Beinan has supported production Presto clusters at Twitter for 2+ years. He is also active in presentations and talks, including:

• Predicting Resource Usage of Future Queries based on 10M Presto Queries @ Presto Meetup
• Presto at Twitter @ PrestoCon
• Twitter Presto 101: SQL on Everything
• How Twitter runs Presto on the Cloud

Per the TSC charter "A Contributor may become a Committer by a majority approval of the existing Committers.", therefore, each TSC member has one vote to cast. Please reply with +1/-1 if you approve/disapprove onboarding Beinan as a committer. 

 

Thanks,

Zhenxiao

--

Bin Fan from phone

+1 (non-binding) 

Beinan has been very helpful on the community and Presto foundation side - with presentations on higher level introductions to Presto as well as deeper tech talk sessions. In addition, he has been very helpful with PR reviews on connectors as well as answering user questions and troubleshooting on slack and other community channels. 

Thank you Beinan! 

- Dipti

On Feb 26, 2021, at 9:05 AM, venkik via lists.prestodb.io <venkik=uber.com@...> wrote:



+1

On Fri, Feb 26, 2021 at 9:04 AM Bin Fan <binfan@...> wrote:

+1

thanks for Beinan’s contribution!

Bin

On Fri, Feb 26, 2021 at 8:51 AM Shixuan Fan via lists.prestodb.io <shixuan=fb.com@...> wrote:

+1

 

From: presto-tsc@... <presto-tsc@...> on behalf of zluo via lists.prestodb.io <zluo=twitter.com@...>
Date: Thursday, February 25, 2021 at 2:36 PM
To: presto-tsc@... <presto-tsc@...>
Subject: [presto-tsc] Nominating Beinan Wang as new committer

 

Hi TSC members,

 

I'd like to nominate Beinan Wang as a committer. Beinan has been working on Presto for 2+ years. Some of his contributions highlights:

• Presto Google Cloud Storage(GCS) connector with authentication and authorization
• Presto Druid connector with aggregation pushdowns
• bug fixes and support for Parquet and dereference pushdown in Presto

Here are Beinan's whole commits:

https://github.com/prestodb/presto/commits?author=beinan

 

Beinan has supported production Presto clusters at Twitter for 2+ years. He is also active in presentations and talks, including:

• Predicting Resource Usage of Future Queries based on 10M Presto Queries @ Presto Meetup
• Presto at Twitter @ PrestoCon
• Twitter Presto 101: SQL on Everything
• How Twitter runs Presto on the Cloud

Per the TSC charter "A Contributor may become a Committer by a majority approval of the existing Committers.", therefore, each TSC member has one vote to cast. Please reply with +1/-1 if you approve/disapprove onboarding Beinan as a committer. 

 

Thanks,

Zhenxiao

--

Bin Fan from phone