|
Re: Nominating Ariel Weisberg
toggle quoted messageShow quoted text
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
To clear up any confusion, let’s keep this vote to committership only, since, as it’s stated in the charter, that needs to happen prior to the vote on TSC membership. Thank you!
I think folks may be a bit confused by the committer vs TSC member discussion.
My recommendation is to separate this into two different votes, committer first and TSC member second. The reason is the second is dependent on the first.
Per the updated charter (https://github.com/prestodb/tsc/blob/master/CHARTER.md
section 2.iii and 2.iv, there is separation from the TSC role and the Committer role. These are the relevant sections of the project charter:
Voting in a Committer
“iii. A Contributor may become a Committer by a majority approval of the existing Committers....”
Voting in a TSC member
"iv. A Committer by default is not a voting TSC member. An
existing TSC voting member can nominate a Committer to be a TSC voting member, which will require approval from the majority of existing TSC voting members."
To clarify the role of the TSC, (https://github.com/prestodb/tsc/blob/master/CHARTER.md
Charter Section 2:
“a) The TSC committee provides oversight to the technical direction of the project, which is the Committers, when issues arise.”
Hope this helps to clarify this. Perhaps Tim, as TSC Chair can confirm as well.
Dipti Borkar
Cofounder & Chief Product Officer | ahana.io
Chair
| Presto Foundation, Community Team
C: 408-512-3394 | T: @dborkar
Big +1 as a nobody (feel free to ignore my vote) :-)
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when I review a contribution
from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
+1 for TSC member
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
- Added support for more fine grained partitioning strategies to better handle skewed queries
- Improved memory utilization reporting and memory limits enforcement
- Optimized the memory footprint of RemoteExchangeOperator
- Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
- Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
- Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
- Ensured the web site continues to run and deploy throughout various infrastructure changes
- Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
--
--
|
|
|
toggle quoted messageShow quoted text
+1
------------------------------------------------------------------ Sent At:2021 May 5 (Wed.) 08:52 Subject:[presto-tsc] Github Status Checks
Hello,
As mentioned in the TSC meeting today, I’d like to enable the Github status checks requirement to the master branch, which means status checks must pass before a PR can be merged. This is to prevent accidental merge of a failing test into
the master branch, or to prevent known failing tests from affecting other PRs. If there’s unrelated flaky tests, then the idea is we should fix these tests or mark them as disabled.
Documentation on Github status checks are here:
https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-status-checks-before-merging
Please give this a +1 if you agree that code should not be merged with known test failures.
Thanks
Tim
|
|
|
Re: Nominating Ariel Weisberg
+1
From: presto-tsc@... <presto-tsc@...> on behalf of Bin Fan <binfan@...>
Sent: Thursday, May 6, 2021 9:08 PM
To: Tim Meehan <tdm@...>
Cc: presto-tsc@... <presto-tsc@...>
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
To clear up any confusion, let’s keep this vote to committership only, since, as it’s stated in the charter, that needs to happen prior to the vote on TSC membership. Thank you!
I think folks may be a bit confused by the committer vs TSC member discussion.
My recommendation is to separate this into two different votes, committer first and TSC member second. The reason is the second is dependent on the first.
Per the updated charter (https://github.com/prestodb/tsc/blob/master/CHARTER.md
section 2.iii and 2.iv, there is separation from the TSC role and the Committer role. These are the relevant sections of the project charter:
Voting in a Committer
“iii. A Contributor may become a Committer by a majority approval of the existing Committers....”
Voting in a TSC member
"iv. A Committer by default is not a voting TSC member. An
existing TSC voting member can nominate a Committer to be a TSC voting member, which will require approval from the majority of existing TSC voting members."
To clarify the role of the TSC, (https://github.com/prestodb/tsc/blob/master/CHARTER.md
Charter Section 2:
“a) The TSC committee provides oversight to the technical direction of the project, which is the Committers, when issues arise.”
Hope this helps to clarify this. Perhaps Tim, as TSC Chair can confirm as well.
Dipti Borkar
Cofounder & Chief Product Officer | ahana.io
Chair
| Presto Foundation, Community Team
C: 408-512-3394 | T: @dborkar
Big +1 as a nobody (feel free to ignore my vote) :-)
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when I review a contribution
from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
+1 for TSC member
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
- Added support for more fine grained partitioning strategies to better handle skewed queries
- Improved memory utilization reporting and memory limits enforcement
- Optimized the memory footprint of RemoteExchangeOperator
- Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
- Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
- Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
- Ensured the web site continues to run and deploy throughout various infrastructure changes
- Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
--
--
|
|
|
Re: Nominating Ariel Weisberg
toggle quoted messageShow quoted text
To clear up any confusion, let’s keep this vote to committership only, since, as it’s stated in the charter, that needs to happen prior to the vote on TSC membership. Thank you!
I think folks may be a bit confused by the committer vs TSC member discussion.
My recommendation is to separate this into two different votes, committer first and TSC member second. The reason is the second is dependent on the first.
Per the updated charter (https://github.com/prestodb/tsc/blob/master/CHARTER.md
section 2.iii and 2.iv, there is separation from the TSC role and the Committer role. These are the relevant sections of the project charter:
Voting in a Committer
“iii. A Contributor may become a Committer by a majority approval of the existing Committers....”
Voting in a TSC member
"iv. A Committer by default is not a voting TSC member. An
existing TSC voting member can nominate a Committer to be a TSC voting member, which will require approval from the majority of existing TSC voting members."
To clarify the role of the TSC, (https://github.com/prestodb/tsc/blob/master/CHARTER.md
Charter Section 2:
“a) The TSC committee provides oversight to the technical direction of the project, which is the Committers, when issues arise.”
Hope this helps to clarify this. Perhaps Tim, as TSC Chair can confirm as well.
Dipti Borkar
Cofounder & Chief Product Officer | ahana.io
Chair
| Presto Foundation, Community Team
C: 408-512-3394 | T: @dborkar
Big +1 as a nobody (feel free to ignore my vote) :-)
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when I review a contribution
from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
+1 for TSC member
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
-
Added support for more fine grained partitioning strategies to better handle skewed queries
-
Improved memory utilization reporting and memory limits enforcement
-
Optimized the memory footprint of RemoteExchangeOperator
-
Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
-
Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
-
Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
-
Ensured the web site continues to run and deploy throughout various infrastructure changes
-
Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
--
|
|
|
Re: Nominating Ariel Weisberg
++1 (non-binding)
I have worked very closely with Ariel on multiple initiatives as part of the foundation, on github issues and the community in general. Ariel is one of the most active participants on github with reviews and helps unblock PRs important for our users, and is also active on slack as well as social channels. He has built strong relationships across the community and is known as one of the go-to experts for Presto. Ariel, you go above and beyond and your effort is much appreciated.
Dipti Borkar
Cofounder & Chief Product Officer | ahana.io Chair | Presto Foundation, Community Team
C: 408-512-3394 | T: @dborkar
On Wed, May 5, 2021 at 1:58 PM Tim Meehan < tdm@...> wrote:
To clear up any confusion, let’s keep this vote to committership only, since, as it’s stated in the charter, that needs to happen prior to the vote on TSC membership. Thank you!
I think folks may be a bit confused by the committer vs TSC member discussion.
My recommendation is to separate this into two different votes, committer first and TSC member second. The reason is the second is dependent on the first.
Per the updated charter (https://github.com/prestodb/tsc/blob/master/CHARTER.md
section 2.iii and 2.iv, there is separation from the TSC role and the Committer role. These are the relevant sections of the project charter:
Voting in a Committer
“iii. A Contributor may become a Committer by a majority approval of the existing Committers....”
Voting in a TSC member
"iv. A Committer by default is not a voting TSC member. An
existing TSC voting member can nominate a Committer to be a TSC voting member, which will require approval from the majority of existing TSC voting members."
To clarify the role of the TSC, (https://github.com/prestodb/tsc/blob/master/CHARTER.md
Charter Section 2:
“a) The TSC committee provides oversight to the technical direction of the project, which is the Committers, when issues arise.”
Hope this helps to clarify this. Perhaps Tim, as TSC Chair can confirm as well.
Dipti Borkar
Cofounder & Chief Product Officer | ahana.io
Chair
| Presto Foundation, Community Team
C: 408-512-3394 | T: @dborkar
Big +1 as a nobody (feel free to ignore my vote) :-)
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when I review a contribution
from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
+1 for TSC member
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
-
Added support for more fine grained partitioning strategies to better handle skewed queries
-
Improved memory utilization reporting and memory limits enforcement
-
Optimized the memory footprint of RemoteExchangeOperator
-
Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
-
Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
-
Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
-
Ensured the web site continues to run and deploy throughout various infrastructure changes
-
Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
--
|
|
|
toggle quoted messageShow quoted text
------------------------------------------------------------------ From:Tim Meehan via lists.prestodb.io <tdm=fb.com@...> Sent At:2021 May 5 (Wed.) 08:52 To:presto-tsc@... <presto-tsc@...> Subject:[presto-tsc] Github Status Checks
Hello,
As mentioned in the TSC meeting today, I’d like to enable the Github status checks requirement to the master branch, which means status checks must pass before a PR can be merged. This is to prevent accidental merge of a failing test into
the master branch, or to prevent known failing tests from affecting other PRs. If there’s unrelated flaky tests, then the idea is we should fix these tests or mark them as disabled.
Documentation on Github status checks are here:
https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-status-checks-before-merging
Please give this a +1 if you agree that code should not be merged with known test failures.
Thanks
Tim
|
|
|
toggle quoted messageShow quoted text
Hello,
As mentioned in the TSC meeting today, I’d like to enable the Github status checks requirement to the master branch, which means status checks must pass before a PR can be merged. This is to prevent accidental merge of a failing test into
the master branch, or to prevent known failing tests from affecting other PRs. If there’s unrelated flaky tests, then the idea is we should fix these tests or mark them as disabled.
Documentation on Github status checks are here:
https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-status-checks-before-merging
Please give this a +1 if you agree that code should not be merged with known test failures.
Thanks
Tim
|
|
|
toggle quoted messageShow quoted text
Hello,
As mentioned in the TSC meeting today, I’d like to enable the Github status checks requirement to the master branch, which means status checks must pass before a PR can be merged. This is to prevent accidental merge of a failing test into
the master branch, or to prevent known failing tests from affecting other PRs. If there’s unrelated flaky tests, then the idea is we should fix these tests or mark them as disabled.
Documentation on Github status checks are here:
https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-status-checks-before-merging
Please give this a +1 if you agree that code should not be merged with known test failures.
Thanks
Tim
|
|
|
Re: Nominating Ariel Weisberg
|
|
|
Re: Nominating Ariel Weisberg
To clear up any confusion, let’s keep this vote to committership only, since, as it’s stated in the charter, that needs to happen prior to the vote on TSC membership. Thank you!
From:
presto-tsc@... <presto-tsc@...> on behalf of Dipti Borkar <dipti@...>
Date: Wednesday, May 5, 2021 at 2:43 PM
To: wenlei.xie@... <wenlei.xie@...>
Cc: Biswapesh Chattopadhyay <biswapesh@...>, Andrii Rosa <andriyrosa@...>, Masha Basmanova <mbasmanova@...>, Rebecca Schlussel <rschlussel@...>, presto-tsc@... <presto-tsc@...>
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
I think folks may be a bit confused by the committer vs TSC member discussion.
My recommendation is to separate this into two different votes, committer first and TSC member second. The reason is the second is dependent on the first.
Per the updated charter (https://github.com/prestodb/tsc/blob/master/CHARTER.md
section 2.iii and 2.iv, there is separation from the TSC role and the Committer role. These are the relevant sections of the project charter:
Voting in a Committer
“iii. A Contributor may become a Committer by a majority approval of the existing Committers....”
Voting in a TSC member
"iv. A Committer by default is not a voting TSC member. An
existing TSC voting member can nominate a Committer to be a TSC voting member, which will require approval from the majority of existing TSC voting members."
To clarify the role of the TSC, (https://github.com/prestodb/tsc/blob/master/CHARTER.md
Charter Section 2:
“a) The TSC committee provides oversight to the technical direction of the project, which is the Committers, when issues arise.”
Hope this helps to clarify this. Perhaps Tim, as TSC Chair can confirm as well.
Dipti Borkar
Cofounder & Chief Product Officer | ahana.io
Chair
| Presto Foundation, Community Team
C: 408-512-3394 | T: @dborkar
toggle quoted messageShow quoted text
On Wed, May 5, 2021 at 11:13 AM < wenlei.xie@...> wrote:
Big +1 as a nobody (feel free to ignore my vote) :-)
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when I review a contribution
from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
+1 for TSC member
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
-
Added support for more fine grained partitioning strategies to better handle skewed queries
-
Improved memory utilization reporting and memory limits enforcement
-
Optimized the memory footprint of RemoteExchangeOperator
-
Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
-
Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
-
Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
-
Ensured the web site continues to run and deploy throughout various infrastructure changes
-
Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
--
|
|
|
Re: Nominating Ariel Weisberg
|
|
|
|
|
|
toggle quoted messageShow quoted text
+1
Hello,
As mentioned in the TSC meeting today, I’d like to enable the Github status checks requirement to the master branch, which means status checks must pass before a PR can be merged. This is to prevent accidental merge of a failing test into
the master branch, or to prevent known failing tests from affecting other PRs. If there’s unrelated flaky tests, then the idea is we should fix these tests or mark them as disabled.
Documentation on Github status checks are here: https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-status-checks-before-merging
Please give this a +1 if you agree that code should not be merged with known test failures.
Thanks
Tim
|
|
|
Re: Nominating Ariel Weisberg
I think folks may be a bit confused by the committer vs TSC member discussion.
My recommendation is to separate this into two different votes, committer first and TSC member second. The reason is the second is dependent on the first.
Per the updated charter (https://github.com/prestodb/tsc/blob/master/CHARTER.md section 2.iii and 2.iv, there is separation from the TSC role and the Committer role.
These are the relevant sections of the project charter:
Voting in a Committer “iii. A Contributor may become a Committer by a majority approval of the existing Committers....”
Voting in a TSC member "iv. A Committer by default is not a voting TSC member. An existing TSC voting member can nominate a Committer to be a TSC voting member, which will require approval from the majority of existing TSC voting members."
To clarify the role of the TSC, (https://github.com/prestodb/tsc/blob/master/CHARTER.md Charter Section 2: “a) The TSC committee provides oversight to the technical direction of the project, which is the Committers, when issues arise.” Hope this helps to clarify this. Perhaps Tim, as TSC Chair can confirm as well.
Dipti Borkar
Cofounder & Chief Product Officer | ahana.io Chair | Presto Foundation, Community Team
C: 408-512-3394 | T: @dborkar
-1 as committer
Big +1 as a nobody (feel free to ignore my vote) :-)
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when
I review a contribution from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
+1 for TSC member
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
- Added support for more fine grained partitioning strategies to better handle skewed queries
- Improved memory utilization reporting and memory limits enforcement
- Optimized the memory footprint of RemoteExchangeOperator
- Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
- Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
- Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
- Ensured the web site continues to run and deploy throughout various infrastructure changes
- Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
|
|
|
Re: Nominating Ariel Weisberg
toggle quoted messageShow quoted text
Big +1 as a nobody (feel free to ignore my vote) :-)
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when
I review a contribution from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
+1 for TSC member
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
- Added support for more fine grained partitioning strategies to better handle skewed queries
- Improved memory utilization reporting and memory limits enforcement
- Optimized the memory footprint of RemoteExchangeOperator
- Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
- Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
- Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
- Ensured the web site continues to run and deploy throughout various infrastructure changes
- Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
|
|
|
Re: Nominating Ariel Weisberg
Big +1 as a nobody (feel free to ignore my vote) :-)
From: presto-tsc@... <presto-tsc@...> on behalf of rschlussel via lists.prestodb.io <rschlussel=fb.com@...>
Sent: Wednesday, May 5, 2021 11:02:16 AM
To: Masha Basmanova <mbasmanova@...>; Andrii Rosa <andriyrosa@...>; presto-tsc@... <presto-tsc@...>
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when
I review a contribution from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
From:
presto-tsc@... <presto-tsc@...> on behalf of Maria Basmanova via lists.prestodb.io <mbasmanova=fb.com@...>
Date: Wednesday, May 5, 2021 at 1:52 PM
To: Andrii Rosa <andriyrosa@...>, presto-tsc@... <presto-tsc@...>
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for TSC member
From:
<presto-tsc@...> on behalf of Andrii Rosa <andriyrosa@...>
Date: Wednesday, May 5, 2021 at 1:32 PM
To: "presto-tsc@..." <presto-tsc@...>
Subject: [presto-tsc] Nominating Ariel Weisberg
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
- Added support for more fine grained partitioning strategies to better handle skewed queries
- Improved memory utilization reporting and memory limits enforcement
- Optimized the memory footprint of RemoteExchangeOperator
- Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
- Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
- Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
- Ensured the web site continues to run and deploy throughout various infrastructure changes
- Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
|
|
|
Re: Nominating Ariel Weisberg
+1 for committer, specifically because of review contributions. I agree with James that the number of personal contributions is less than usual. However, the number and quality of reviews higher. Both when he reviews my PRs, and when
I review a contribution from someone else that he has already reviewed, I’ve found his reviews to be very insightful and thorough. Code review is one of the main responsibilities for a committer, so I think the large number of reviews gives good signal.
From:
presto-tsc@... <presto-tsc@...> on behalf of Maria Basmanova via lists.prestodb.io <mbasmanova=fb.com@...>
Date: Wednesday, May 5, 2021 at 1:52 PM
To: Andrii Rosa <andriyrosa@...>, presto-tsc@... <presto-tsc@...>
Subject: Re: [presto-tsc] Nominating Ariel Weisberg
+1 for TSC member
From: <presto-tsc@...> on behalf of Andrii Rosa <andriyrosa@...>
Date: Wednesday, May 5, 2021 at 1:32 PM
To: "presto-tsc@..." <presto-tsc@...>
Subject: [presto-tsc] Nominating Ariel Weisberg
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
-
Added support for more fine grained partitioning strategies to better handle skewed queries
-
Improved memory utilization reporting and memory limits enforcement
-
Optimized the memory footprint of RemoteExchangeOperator
-
Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
-
Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
-
Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
-
Ensured the web site continues to run and deploy throughout various infrastructure changes
-
Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
|
|
|
Re: Nominating Ariel Weisberg
+1 for TSC member
From: <presto-tsc@...> on behalf of Andrii Rosa <andriyrosa@...>
Date: Wednesday, May 5, 2021 at 1:32 PM
To: "presto-tsc@..." <presto-tsc@...>
Subject: [presto-tsc] Nominating Ariel Weisberg
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
-
Added support for more fine grained partitioning strategies to better handle skewed queries
-
Improved memory utilization reporting and memory limits enforcement
-
Optimized the memory footprint of RemoteExchangeOperator
-
Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
-
Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
-
Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
-
Ensured the web site continues to run and deploy throughout various infrastructure changes
-
Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
|
|
|
Re: Nominating Ariel Weisberg
-1, but propose to have TSC member only
Ariel has contributed a lot to our community with close collaboration with many of our partner companies. He is extremely active in Slack channels and reviews. I don’t think Presto community can be successfully without Ariel. However, the
contribution from Presto codebase itself might not be sufficient. This casts an uncertainty on the committership.
We understand TSC members are all committers. But we have discussed this before if it’s possible to separate these two roles. Wonder if we could discuss on that? I’m fully supportive on Ariel to be part of TSC.
Thanks
James
From:
presto-tsc@... <presto-tsc@...> on behalf of Andrii Rosa <andriyrosa@...>
Date: Wednesday, May 5, 2021 at 10:32 AM
To: presto-tsc@... <presto-tsc@...>
Subject: [presto-tsc] Nominating Ariel Weisberg
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
-
Added support for more fine grained partitioning strategies to better handle skewed queries
-
Improved memory utilization reporting and memory limits enforcement
-
Optimized the memory footprint of RemoteExchangeOperator
-
Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
-
Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
-
Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
-
Ensured the web site continues to run and deploy throughout various infrastructure changes
-
Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
|
|
|
Re: Nominating Ariel Weisberg
+1 for both committer and TSC member
From:
presto-tsc@... <presto-tsc@...> on behalf of Andrii Rosa <andriyrosa@...>
Date: Wednesday, May 5, 2021 at 1:32 PM
To: presto-tsc@... <presto-tsc@...>
Subject: [presto-tsc] Nominating Ariel Weisberg
I would like to nominate Ariel Weisberg for both committer and TSC membership.
From the very first day working at Presto Ariel has been one of the most active members of the Presto open source community. He has made substantial contributions to establishing the Presto Foundation, defining community guidelines and building relations with
other companies. Currently Ariel is also one of the most active Facebook engineers in the PrestoDB Slack who is actively engaging with the external Presto community by answering their questions, helping to resolve the issues they are facing, and connecting
them with experts in a specific area if needed.
Ariel has reviewed 104 PR's with the total of 32109 LoC from 30 authors, 12 of which are external contributors from the community. Ariel provided code review and all required support to land Hive 3.0 integration, a large contribution from the community that
had been a major blocker for broader Presto adoption.
Pull requests reviewed and accepted by Ariel meet the community standard. In those cases when Ariel didn't have enough context to provide a code review he has been able to identify area owners and loop them into the review process.
As his personal contributions Ariel:
-
Added support for more fine grained partitioning strategies to better handle skewed queries
-
Improved memory utilization reporting and memory limits enforcement
-
Optimized the memory footprint of RemoteExchangeOperator
-
Migrated CI from Travis to Github Actions when the project was blocked on Travis allowing us to save hundreds of thousands on CI and improving test runtime and stability
-
Restored the lost Docker containers used for product and integration testing and reenabled these tests on CI
-
Added the blog to the web site, solicited, edited, and reviewed many of the blog posts
-
Ensured the web site continues to run and deploy throughout various infrastructure changes
-
Maintained the GH organization memberships and permissions and other integrations
Please respond whether you support Ariel as a committer or a TSC member or both.
|
|
|
