Re: Allowing external checks on Github PR

Swapnil Tailor


Along with the rule of adding external checks, we should also be having rule around when to remove external checks.
i.e. if the checks keep failing for certain period of time and not fixed, then we should remove them. 
Reason: It's good to have not have broken checks for long period of time so we won't start ignoring them if they fail long enough. 

On Thu, Mar 26, 2020 at 9:25 AM venkik via Lists.Prestodb.Io <> wrote:

On Wed, Mar 25, 2020 at 10:29 PM <rongrong100@...> wrote:

On Wed, Mar 25, 2020 at 4:02 PM <wenlei.xie@...> wrote:

On Wed, Mar 25, 2020 at 15:06 Leiqing Cai <caithagoras@...> wrote:
I'd like to propose allowing additional external checks on Github PR. Specifically, I'm looking to a test to check for Facebook integration.

Currently, Travis CI is run on each PR (shown in the screenshot below).
However, this is not enough since there are active repos depending upon the master of prestodb/presto.
Allowing adding external integration checks can help identify breakages earlier on.

Here are the rules that I propose for external checks:
- Anyone can add external checks upon TSC approval.
- Test owner should make sure that the test is not flaky.
- Test failures does not block merging. They only serves alerting purpose.



Join to automatically receive all group messages.