- Allowing external checks on Github PR
Re: Allowing external checks on Github PR
+1 and thanks for doing this!
From: <presto-tsc@...> on behalf of Leiqing Cai <caithagoras@...>
Date: Wednesday, March 25, 2020 at 3:06 PM
To: "presto-tsc@..." <presto-tsc@...>
Subject: [presto-tsc] Allowing external checks on Github PR
I'd like to propose allowing additional external checks on Github PR. Specifically, I'm looking to a test to check for Facebook integration.
Currently, Travis CI is run on each PR (shown in the screenshot below).
However, this is not enough since there are active repos depending upon the master of prestodb/presto.
Allowing adding external integration checks can help identify breakages earlier on.
Here are the rules that I propose for external checks:
- Anyone can add external checks upon TSC approval.
- Test owner should make sure that the test is not flaky.
- Test failures does not block merging. They only serves alerting purpose.
Join email@example.com to automatically receive all group messages.