Re: Github Status Checks


Bin Fan
 

+1

Bin Fan

On Wed, May 5, 2021 at 6:39 PM <rongrong100@...> wrote:
+1
Rongrong


On Tue, May 4, 2021 at 5:49 PM Tim Meehan via lists.prestodb.io <tdm=fb.com@...> wrote:

Hello,

 

As mentioned in the TSC meeting today, I’d like to enable the Github status checks requirement to the master branch, which means status checks must pass before a PR can be merged.  This is to prevent accidental merge of a failing test into the master branch, or to prevent known failing tests from affecting other PRs.  If there’s unrelated flaky tests, then the idea is we should fix these tests or mark them as disabled.

 

Documentation on Github status checks are here: https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-status-checks-before-merging

 

Please give this a +1 if you agree that code should not be merged with known test failures.

 

Thanks

Tim

--
Bin Fan from phone

Join presto-dev@lists.prestodb.io to automatically receive all group messages.